cl: preserve expanded Gloas lifecycle hardening - #23249
Draft
domiwei wants to merge 17 commits into
Draft
Conversation
Member
Author
|
Carried review feedback from #22683 This draft preserves code removed from the slim PR; it does not imply that the removed implementation is ready to merge. Before any cluster is promoted into a follow-up PR, retain and re-evaluate the applicable review findings from #22683, including:
The inline threads on #22683 were resolved there because their referenced code is absent from the slim diff, not because these concerns were waived. This draft remains a holding branch and should be decomposed into dependency-ordered PRs with each applicable finding addressed and retested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This draft preserves the broader Gloas hardening work extracted from #22683 so the original checkpoint-sync fix can remain small and mergeable.
It is intentionally stacked on #22683. Review should wait until that PR lands and this branch is rebased onto
main.Included follow-up clusters
Status
Draft only. The preserved branch contains the complete expanded implementation and tests, but it still needs decomposition and focused lifecycle work before review:
Those risks are intentionally quarantined here and are not part of #22683.
The next step is to split this holding PR into coherent dependency-ordered follow-ups rather than merge it as one unit.